[Webkit-unassigned] [Bug 145992] Strict Equality on objects should only check that one of the two sides is an object.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 24 10:58:12 PDT 2015


--- Comment #33 from Mark Lam <mark.lam at apple.com> ---
(In reply to comment #32)
> Comment on attachment 255486 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255486&action=review
> > Source/JavaScriptCore/tests/stress/equality-type-checking.js:23
> > +if (address === undefined)
> Since address is a Number, we should fail with the type check part of ===
> and never get to compare "address" with the Cell*.  I'm trying to figure out
> how comparing against the address as a number adds to the testing.

The bug he is testing for is that there’s a 32-bit case where he / someone forgot to compare the tag as well.  In that case, the number would masquerade as the cell.  This test ensures that === compares the tag as well.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/fc1f7b53/attachment.html>

More information about the webkit-unassigned mailing list