[Webkit-unassigned] [Bug 146253] MediaSession: Support setting of metadata

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146253

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255464|review?                     |review+
              Flags|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 255464
  --> https://bugs.webkit.org/attachment.cgi?id=255464
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255464&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:39
> +    : m_scriptExecutionContext(&context)

Unless you will need the ScriptExecutionContext for something else later, I think we should capture a reference to the document instead as the only thing we do with the ScriptExecutionContext is get its document.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/562882fa/attachment-0001.html>