[Webkit-unassigned] [Bug 146177] AX: AXObjectCache should try to use an unignored accessibilityObject when posting a selection notification when on the border between two accessibilityObjects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 23 17:01:06 PDT 2015


--- Comment #6 from Darin Adler <darin at apple.com> ---
(In reply to comment #4)
> Can adopt just be a free function in JSRetainPtr.h like
> template<typename T> JSRetainPtr<T> adopt(T value)
> {
>     return JSRetainPtr<T>(Adopt, value);
> }
> or should it be a static method on JSRetainPtr (or something else)?

It can and should be something like that, but that template is too generic and would apply to too many different classes. Instead we should just do overloading, I think:

    inline JSRetainPtr<JSStringRef> adopt(JSStringRef string)
        return JSRetainPtr<JSStringRef>(Adopt, string);

We can overload for other types as needed. Not sure what types JSRetainPtr supports.

Later we will want to make the JSRetainPtr constructor for Adopt be private and move to this function exclusively.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150624/941a6063/attachment.html>

More information about the webkit-unassigned mailing list