[Webkit-unassigned] [Bug 146203] [WinCairo] WebDownload::initWithRequest is not implemented.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 22 14:24:26 PDT 2015


--- Comment #4 from peavo at outlook.com ---
(In reply to comment #2)

Thanks for reviewing :)

> Does this make it so we can finally download things from within WinLauncher?

Unfortunately, no. WinLauncher crashes for me when I try to download a link, but I don't think it would take much work to fix this crash and get downloading from WinLauncher to work.

> > Source/WebKit/win/WebDownloadCurl.cpp:186
> > +        // If destination is already set, we don't need to ask delegate.
> > +        if (!m_destination.isEmpty())
> > +            return;
> Is this correct?  What if the destination is already set but we want to
> change it?

Good point, I removed this in the latest patch.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150622/5086d2ea/attachment.html>

More information about the webkit-unassigned mailing list