[Webkit-unassigned] [Bug 146157] PageLoadState::didCommitLoad should not have hasInsecureContent parameter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 20 07:15:53 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146157

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
I've been thinking about this more. It's hard to think of a good alternative name for this parameter, and in a certain sense it does exactly what it says: the PageLoadState _at the time of the call_ will be reset to either secure or insecure, and if set to secure it will simply be changed to insecure a bit later down the road. This is confusing, but the current code is probably best so long as we're performing extra security checks in WebPageProxy (not ideal).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150620/03d90782/attachment.html>


More information about the webkit-unassigned mailing list