[Webkit-unassigned] [Bug 146080] Web Inspector: Fix shape-highlight layout tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 17 15:09:44 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=146080
Joseph Pecoraro <joepeck at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #255040|review? |review-
Flags| |
--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 255040
--> https://bugs.webkit.org/attachment.cgi?id=255040
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=255040&action=review
> Source/WebCore/inspector/InspectorOverlay.cpp:668
> - shapeObject->setMarginShape(shapePath.copyRef());
> + shapeObject->setMarginShape(marginShapePath.copyRef());
Yay!
> LayoutTests/http/tests/inspector/dom/shapes-test.js:35
> + InspectorTest.assert(!error, "When evaluating code, received unexpected error:" + error);
> + InspectorTest.assert(!error, "When evaluating code, an exception was thrown:" + wasThrown);
Missing LayoutTests/ChangeLog entry for the updates to this file. r- so you can add a changelog. Otherwise the patch looks great!
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150617/0f57b0ec/attachment.html>
More information about the webkit-unassigned
mailing list