[Webkit-unassigned] [Bug 145978] Media Session: Active participating elements can change while being enumerated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 15 10:39:46 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=145978

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254881|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 254881
  --> https://bugs.webkit.org/attachment.cgi?id=254881
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254881&action=review

Needs rebasing and some minor changes, but looks good to me.

> Source/WebCore/ChangeLog:3
> +        Media Session: Active participating elements can change while being enumerated 

enumerated -> iterated

> Source/WebCore/Modules/mediasession/MediaSession.cpp:97
> +    HashSet<HTMLMediaElement*> activeParticipatingElements = m_activeParticipatingElements;

activeParticipatingElementsCopy to make it clear what is going on here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150615/ef7ca111/attachment.html>


More information about the webkit-unassigned mailing list