[Webkit-unassigned] [Bug 145829] Explicitly keep track of active HTMLMediaElements in MediaSessions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145829

--- Comment #6 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #4)
> Comment on attachment 254619 [details]
> Patch (re-based)
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254619&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:2836
> > +        if (m_readyState == HAVE_CURRENT_DATA || m_readyState == HAVE_FUTURE_DATA) {
> > +            if (m_session)
> > +                m_session->addActiveMediaElement(*this);
> > +        }
> 
> As we do elsewhere in this file, please include a comment with the text from
> the media session spec to explain why this is happening:
> 
> // https://mediasession.spec.whatwg.org/#activating-a-media-session
> // 6.3. Activating a media session from a media element
> // When the play() method on a media element is invoked and ...
> // 1. Let media session be the value of media element’s current media
> session.
> // 2.  ...
> 
> etc.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150610/044c3997/attachment.html>