[Webkit-unassigned] [Bug 145806] Implement MediaSessionManager to keep track of all MediaSessions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 9 12:14:35 PDT 2015


--- Comment #5 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #3)
> Comment on attachment 254580 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254580&action=review
> > Source/WebCore/Modules/mediasession/MediaSessionManager.cpp:49
> > +    m_sessions.remove(m_sessions.find(&session));
> Normally it’s not good to use remove/find. I’d suggest using a HashSet or
> ListHashSet for this collection instead of a vector.

Settled on HashSet since we don't care about the ordering of MediaSessions. Thanks!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150609/150aba8f/attachment.html>

More information about the webkit-unassigned mailing list