[Webkit-unassigned] [Bug 145800] NetworkCache: Delete old cache versions
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 9 09:57:17 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=145800
Chris Dumez <cdumez at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #254568|review+ |review?
Flags| |
--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 254568
--> https://bugs.webkit.org/attachment.cgi?id=254568
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=254568&action=review
> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:62
> + struct dirent* dp;
I think the "struct" is superfluous in C++.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:69
> + function(String(name), directoryEntryType(dp->d_type));
Probably not a big deal for what you're using it for but this likely only works if the name only include latin1 characters. I think String::fromUTF8(name) would be more correct.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:94
> + struct stat fileInfo;
struct is superfluous I believe.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.cpp:121
> + utimes(WebCore::fileSystemRepresentation(path).data(), 0);
nullptr
> Source/WebKit2/NetworkProcess/cache/NetworkCacheFileSystem.h:2
> + * Copyright (C) 2015 Apple Inc. All rights reserved.
Not commenting on this file as it seems it is the diff being confused.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:876
> + String versionString = subdirName.substring(strlen(versionDirectoryPrefix));
We could use sizeof(versionDirectoryPrefix)-1 to resolve this at compile time instead of iterating over the string at runtime.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150609/208ebb5f/attachment.html>
More information about the webkit-unassigned
mailing list