[Webkit-unassigned] [Bug 145797] [SOUP] Network Cache: run the IO completion handler in the given queue instead of the whole operation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145797

--- Comment #3 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 254561
  --> https://bugs.webkit.org/attachment.cgi?id=254561
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254561&action=review

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:119
> +            auto asyncData = std::unique_ptr<ReadAsyncData>(asyncDataPtr);

This can be just

    std::unique_ptr<ReadAsyncData> asyncData(asyncDataPtr);

Same for the rest of such statements.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:188
> +            Data data;
> +            completionHandler(data, -1);

You could probably just construct the Data object in the completionHandler call:

    completionHandler(Data(), -1);

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:191
> +        g_cond_wait(&condition, &mutex);

Can this function be called on the main thread, with a null queue?

That would schedule the callback in the main context and continue to block the main thread in g_cond_wait(), with the callback never invoked.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:223
>      g_cond_wait(&condition, &mutex);

Same problem here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150609/5a805ca7/attachment.html>