[Webkit-unassigned] [Bug 144955] [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144955

--- Comment #53 from GSkachkov <gskachkov at gmail.com> ---
(In reply to comment #47)
> Comment on attachment 254239 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254239&action=review
> 
> I can review (partially) this if it's limited to parser's change. In
> profiler part, I think I'm not a right reviewer.
> 
> > Source/JavaScriptCore/parser/Parser.cpp:2023
> > +    bool doParseConditionalExpression = false;
> 
> I think `shouldParseConditionalExpression` is better.
> 
> > Source/JavaScriptCore/parser/Parser.cpp:2027
> > +    doParseConditionalExpression = !isArrowFunctionEmptyParamterList();
> 
> In isArrowFunctionEmptyPararmeterList, we create SavePoint. So I think the
> above `createSavevPoint` and SavePoint are duplicate.
> Could you change to the implementation that
> `isArrowFunctionEmptyParamterList` always restore the state?
> With that implementation, the above SavePoint is not necessary.

I've fixed last comments. What do you think, who can help with profiler part?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150607/1eab7ece/attachment.html>