[Webkit-unassigned] [Bug 138812] Web Inspector: Ability to Copy entire CSS Rule from Styles Sidebar

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=138812

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254272|review?                     |review-
              Flags|                            |

--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 254272
  --> https://bugs.webkit.org/attachment.cgi?id=254272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254272&action=review

I think a context menu on the rule section would be best.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css:70
> +    cursor: pointer;

Not sure pointer is the right cursor. This might be best as a context menu item. Click to Copy isn't a typical user action in most places.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.js:110
> +    (function(thisObject) {
> +        thisObject._iconElement.addEventListener("click", function() {

You should use .bind(this) on the event listener function instead. No need for a closure.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150604/832994d2/attachment-0001.html>