[Webkit-unassigned] [Bug 144955] [ES6] Implement ES6 arrow function syntax. Parser of arrow function with execution as common function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144955

--- Comment #45 from GSkachkov <gskachkov at gmail.com> ---
(In reply to comment #40)
> (In reply to comment #39)
> > 1. Source/JavaScriptCore/parser/ParserTokens.h:79
> > I've added new value ARROWFUNCTION and followed the same style as all enums
> > in this file
> > http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/parser/
> > ParserTokens.h#L75
> 
> This one is really strange. I’m not sure why we decided to use all caps for
> all these tokens. Worth discussing with someone, but for now I suppose you
> should match the style.
> 
> > 2. Source/JavaScriptCore/parser/Parser.h 
> > In this file I've added new parameter with default value in exist function.
> > I've used default value to decrease number of changes, so to default value I
> > had to add name of the parameter.
> > 
> > template <class TreeBuilder> TreeStatement parseStatement(TreeBuilder&,
> > const Identifier*& directive, unsigned* directiveLiteralLength = 0,
> > !!!!FunctionParseType functionParseType = StandardFunctionParseType!!!!)
> 
> You don’t need am argument name to have a default value:
> 
>     [...] unsigned* directiveLiteralLength = nullptr, FunctionParseType =
> StandardFunctionParseType)

Thanks for hint! I've loaded new version with fix. Could you please suggest what I need to fix also in this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150604/2529dcc7/attachment.html>