[Webkit-unassigned] [Bug 141262] Web Inspector: if a known CSS property has an unsupported value, only strikethrough the value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141262

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254219|review?                     |review+
              Flags|                            |

--- Comment #4 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 254219
  --> https://bugs.webkit.org/attachment.cgi?id=254219
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254219&action=review

Awesome!

> Source/WebInspectorUI/UserInterface/Models/CSSCompletions.js:279
> +    nameMatchesValidPropertyExactly(name)

Do we need to do anything special for properties that can have a "-webkit-" prefix or not? Like transform can, and some others.

> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:542
> +            this._codeMirror.markText(start, end, {className: "invalid"});

Will this marker get cleared when edits are made to make the value valid?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150604/5cc4f32f/attachment.html>