[Webkit-unassigned] [Bug 145582] streamline benchmark-runner browser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145582

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254127|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 254127
  --> https://bugs.webkit.org/attachment.cgi?id=254127
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254127&action=review

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:32
> +        process = subprocess.Popen(['open', '-a', appPath] + args)
> +        cls.launchCaffeinateForProcess(process.pid)

Instead of having a helper function to launch caffinate, why don't we add a method e.g. launchProcessWithCaffinate that launches both the target process and caffeinate?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:43
> +        subprocess.Popen(["/usr/bin/caffeinate", "-disw", str(pid)])

Does caffeinate automatically terminate?

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:39
> +        self.safariProcess = subprocess.Popen(args, env=env)
> +
> +        OSXSafariDriver.launchCaffeinateForProcess(self.safariProcess.pid)

That way, we can just call that function instead of Popen'ing and calling a separate helper function.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150603/492942a6/attachment.html>