[Webkit-unassigned] [Bug 145530] Add stub implementation of MediaSession, part of Media Session spec

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145530

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254071|review?                     |review+
              Flags|                            |

--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 254071
  --> https://bugs.webkit.org/attachment.cgi?id=254071
Patch (revised)

View in context: https://bugs.webkit.org/attachment.cgi?id=254071&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:48
> +    MediaRemoteControls* controls = m_controls.get();
> +    isNull = controls == nullptr;
> +    return controls;

WebKit style is to test for a NULL object with "!", so something like the following would be better:

  isNull = !m_controls;
  return controls.get();

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150602/7417e286/attachment.html>