[Webkit-unassigned] [Bug 145307] EWS provides misleading information for not applyable patches

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 1 05:19:07 PDT 2015


Csaba Osztrogonác <ossy at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |ossy at webkit.org

--- Comment #4 from Csaba Osztrogonác <ossy at webkit.org> ---
(In reply to comment #3)
> Style checker is clearly wrong, but how did you determine that other bubbles
> in <https://bugs.webkit.org/show_bug.cgi?id=145247> are green for a wrong
> reason?

The problem is that webkit-patch tries to apply the patch, but there is no
appliable diff in the patch. In this case the green GTK/Mac/EFL bubbles
mean that the trunk is buildable, nothing else. It is very misleading.

I think the best fix would be to make svn-apply not to return 0 in this case.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150601/f8ee70c0/attachment.html>

More information about the webkit-unassigned mailing list