[Webkit-unassigned] [Bug 147322] Media Session: give media elements unique IDs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147322

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257565|review?                     |review+
              Flags|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 257565
  --> https://bugs.webkit.org/attachment.cgi?id=257565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257565&action=review

As we discussed offline, please file a bug about consolidating this with the MediaPlaybackTargetClient map.

> Source/WebCore/html/HTMLMediaElement.cpp:435
> +    static uint64_t elementID = 0;
> +    m_elementID = ++elementID;

Nit: we usually put something like this in a static function, eg. uint64_t nextPlaybackTargetClientContextId() in Document.cpp.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150801/ed18e84e/attachment.html>