[Webkit-unassigned] [Bug 147316] Web Inspector: Autocomplete: Undo (Cmd+Z) doesn't work as expected

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147316

drousso at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257895|                            |review?, commit-queue?
              Flags|                            |

--- Comment #2 from drousso at apple.com ---
Created attachment 257895
  --> https://bugs.webkit.org/attachment.cgi?id=257895&action=review
[Proposed] Patch

The reason for this is because the "replaceRange" call in "WebInspector.CodeMirrorCompletionController._applyCompletionHint" causes CodeMirror to add another history state, and that addition messes up the previous history states (each time the user changes the text, replaceRange is called, therefore interrupting the collating of history events).  Using "setUniqueBookmark" allows us to keep the history state accurate while also displaying the current completion.  There are some small setbacks (it does not have all of the styling as before), but the benefits of being able to undo nicely outweigh those drawbacks (in my opinion at least).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150731/569ba2c6/attachment.html>