[Webkit-unassigned] [Bug 147414] Media Session: test Play/Pause media control events delivered to non-Content media sessions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147414

--- Comment #4 from Matt Rajca <mrajca at apple.com> ---
(In reply to comment #3)
> Comment on attachment 257774 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=257774&action=review
> 
> > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:31
> > +            video.play();
> 
> Nit: If you want to add the event listener with "video.on<event type>", I
> think it will make the test results easier to understand if you log the
> event name as you would if you used waitForEvent, eg:
> 
> consoleWrite("EVENT(" + event.type + ")");

I switched to `waitForEvent`.

> 
> > LayoutTests/media/session/play-pause-media-events-in-non-content-sessions.html:62
> > +    <p>'Transient' sessions should not respond to Play/Pause media control events.</p>
> 
> You are testing both transient and ambient sessions.

Good catch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150730/851c4599/attachment.html>