[Webkit-unassigned] [Bug 147295] AX: VoiceOver unable to access content in malformed trees

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147295

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257795|review?                     |review-
              Flags|                            |

--- Comment #15 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 257795
  --> https://bugs.webkit.org/attachment.cgi?id=257795
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257795&action=review

thanks. almost there

> Source/WebCore/ChangeLog:9
> +        VoiceOver is skipping the content of malformed trees. Fixed it by ignoring

VoiceOver is skipping the content of malformed trees.
This fixes the problem by having the tree check if it has valid children (tree items) and makes tree items check if they are inside trees.

> Source/WebCore/accessibility/AccessibilityObject.h:776
> +    // Function to determine if the attribute role should be ignored

this comment probably not necessary. your method name does the same thing that this comment says

> Source/WebCore/accessibility/AccessibilityTree.cpp:72
> +    // A valid tree can only have treeitem or group of treeitems as child

"... as a child."

> Source/WebCore/accessibility/AccessibilityTree.cpp:75
> +    Deque<Node*> queue;

we should make this queue after we check if there's node (next line)

> Source/WebCore/accessibility/AccessibilityTree.cpp:85
> +        Node* child = queue.takeFirst();

auto child

> Source/WebCore/accessibility/AccessibilityTree.cpp:89
> +        if (nodeHasRole(child, "treeitem"))

does nodeHasRole already check the is<Element> for us? we might be able to get rid of that check

> Source/WebCore/accessibility/AccessibilityTreeItem.cpp:56
> +    m_isTreeItemValid = false;

it looks like we don't need to initialize this to anything so the line below will take care of it

> Source/WebCore/accessibility/AccessibilityTreeItem.cpp:58
> +    // Walk the parent chain looking for a parent that is a tree, treeitem is considered

// Walk the parent chain looking for a parent that is a tree. A tree item is only considered valid if it is in a tree.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150730/91f42ef7/attachment.html>