[Webkit-unassigned] [Bug 147295] AX: VoiceOver unable to access content in malformed trees

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147295

--- Comment #13 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 257712
  --> https://bugs.webkit.org/attachment.cgi?id=257712
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257712&action=review

thanks

> Source/WebCore/ChangeLog:9
> +        VoiceOver is skipping the content of the malformed trees. Fixed it by ignoring

VoiceOver is skipping the content of malformed trees. Fixed it by ignoring the tree/treeitem attribute roles for those malformed trees.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2505
> +    if (m_ariaRole != UnknownRole && !shouldIgnoreAriaRole)

put this into the if statement for brevity
shouldIgnoreAttributeRole();

> Source/WebCore/accessibility/AccessibilityRenderObject.h:213
> +    virtual bool shouldIgnoreAttributeRole() const { return false; }

i would put this on AccessibilityObject

> Source/WebCore/accessibility/AccessibilityTree.cpp:75
> +    std::queue<Node*> nodeQueue;

lets use Dequeue here

> Source/WebCore/accessibility/AccessibilityTree.cpp:88
> +        if (is<Element>(*child)) {

i think we can cut down a lot of code using nodeHasRole(node, "tree item") || nodeHas("group")

> Source/WebCore/accessibility/AccessibilityTree.cpp:99
> +            for (Node* groupChild = child->firstChild(); groupChild; groupChild = groupChild->nextSibling())

i think we can use auto in more places here

> Source/WebCore/accessibility/AccessibilityTree.h:46
> +    bool isTreeValid();

i think this can be const

> Source/WebCore/accessibility/AccessibilityTreeItem.cpp:60
> +    AccessibilityObject* axObj = parentObject();

i think we can write this as one for loop line

AXObject *ax= nullptr;
for ( = parent; parent && !parent->IsTreE(); parent = next parent) {}

m_isTreeValid = parent;

> LayoutTests/platform/mac/accessibility/malformed-tree.html:38
> +    shouldBe("tree.role", "\"AXRole: AXOutline\"");

"\"AXRole: AXOutline\"" =>

"'AXRole: AXOutline'"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150729/4387d1f8/attachment-0001.html>