[Webkit-unassigned] [Bug 147320] Use _NSScrollingPredominantAxisFilter for wheel event filtering on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147320

Wenson Hsieh <wenson_hsieh at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257603|review?                     |
              Flags|                            |

--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 257603
  --> https://bugs.webkit.org/attachment.cgi?id=257603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257603&action=review

> Source/WebCore/page/EventHandler.cpp:2791
> +    FloatSize filteredDelta(-wheelEvent->deltaX(), -wheelEvent->deltaY());

This is strange. The delta is passed into the filter points in the opposite direction as the delta received in this function, so this negative sign is just here for now as a hack to make unfiltered scrolling go in the right direction. I'll look into this...

> Source/WebCore/page/MainFrame.cpp:38
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101100

^ whoops, my bad. This changes things...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150727/415ed055/attachment.html>