[Webkit-unassigned] [Bug 147286] New: check-webkit-style should ignore template specializations when warning about inappropriate identifier names

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 24 18:18:27 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=147286

            Bug ID: 147286
           Summary: check-webkit-style should ignore template
                    specializations when warning about inappropriate
                    identifier names
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Minor
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

In bug #147057:

ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:27:  default_delete::operator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:32:  default_delete::operator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/platform/graphics/freetype/UniquePtrFreeType.cpp:37:  default_delete::operator is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 3 in 15 files

But these are template specializations of templates that are not declared by WebKit (default_delete is actually in namespace std, but that's irrelevant), so they have to be named that.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150725/807aa99b/attachment.html>


More information about the webkit-unassigned mailing list