[Webkit-unassigned] [Bug 147252] [MSE] Incorrect sample timestamps when using "sequence" mode

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147252

Jer Noble <jer.noble at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257441|review?                     |review-
              Flags|                            |

--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 257441
  --> https://bugs.webkit.org/attachment.cgi?id=257441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257441&action=review

This patch looks really good! One quibble:

> LayoutTests/media/audio-test.js:1
> +

There's no need to copy video-test.js -> audio-test.js; it's used to test <audio> elements (and <video> elements with audio-only media) as well. If there's any functionality you need which is missing from video-test.js, I'd rather have you add it to video-test.js.

So I'm r-'ing this for now, but this patch can definitely be r+'d with that change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150724/debd92ae/attachment.html>