[Webkit-unassigned] [Bug 147051] Add support for new.target.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 21 09:50:33 PDT 2015
https://bugs.webkit.org/show_bug.cgi?id=147051
--- Comment #12 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 257099
--> https://bugs.webkit.org/attachment.cgi?id=257099
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=257099&action=review
>>>> Source/JavaScriptCore/parser/ASTBuilder.h:183
>>>> + ExpressionNode* newTargetExpr(const JSTokenLocation location)
>>>
>>> small nit: We usually try to name things that create AST nodes "createX".
>>> So here, "createNewTargetNode" or "createNewTargetExpression".
>>
>> Is there a reason why thisExpr and superExpr don't follow this rule? I named my function "newTargetExpr" since new.target is similar to this but for constructors, so I was trying to emulate those functions.
>
> Ah, I guess they are just overlooked ones. Could you rename them to createThisExpr, createSuperExpr etc. at the same time?
I'm not a huge fan of mixing new code with refactors, in case things get rolled out. I'll throw another patch up with that fix.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150721/c2e1b6d9/attachment.html>
More information about the webkit-unassigned
mailing list