[Webkit-unassigned] [Bug 147039] REGRESSION(r184376): [SOUP] ASSERTION FAILED: !m_adoptionIsRequired when downloading file

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147039

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[SOUP] ASSERTION FAILED:    |REGRESSION(r184376): [SOUP]
                   |!m_adoptionIsRequired when  |ASSERTION FAILED:
                   |downloading file            |!m_adoptionIsRequired when
                   |                            |downloading file

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
<MagicSchoolBus>Carrrrlos!</MagicSchoolBus>

You have to either adopt the ref before assigning to the RefPtr:

    // We don't adopt the ref, as it will be released by cleanupSoupRequestOperation, which should always run.
    RefPtr<ResourceHandle> newHandle = new ResourceHandle(d->m_context.get(), firstRequest(), nullptr, d->m_defersLoading, d->m_shouldContentSniff);

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150721/3536d2d7/attachment.html>