[Webkit-unassigned] [Bug 147052] AX: Selection change as a result of focusing an element may cause Safari to crash

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147052

chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257129|review?                     |review-
              Flags|                            |

--- Comment #14 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 257129
  --> https://bugs.webkit.org/attachment.cgi?id=257129
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257129&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1687
> +    // To fix it, added a RefPtr to hold the object long enough and also created a cache for the axObjectCache().

Comment -->

"When a node is told to set focus, that can cause it to be deallocated, which means that doing anything else inside this object will crash.
To fix this, we added a RefPtr to protect this object long enough for duration. We can also locally cache the axObjectCache."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150720/9b210cc5/attachment.html>