[Webkit-unassigned] [Bug 137116] [GTK] Add selection-changed signal to the WebKit2 API

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 20 01:33:53 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=137116

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257081|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #25 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 257081
  --> https://bugs.webkit.org/attachment.cgi?id=257081
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257081&action=review

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:51
> +        GRefPtr<WebKitDOMDOMWindow> domWindow = adoptGRef(webkit_dom_document_get_default_view(document));

g_assert(WEBKIT_DOM_IS_DOM_WINDOW(domWindow.get()));

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:52
> +        GRefPtr<WebKitDOMDOMSelection> domSelection = adoptGRef(webkit_dom_dom_window_get_selection(domWindow.get()));

And same here for the selection.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:62
> +        GRefPtr<WebKitDOMDOMWindow> domWindow = adoptGRef(webkit_dom_document_get_default_view(document));
> +        GRefPtr<WebKitDOMDOMSelection> domSelection = adoptGRef(webkit_dom_dom_window_get_selection(domWindow.get()));

Ditto.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:72
> +        GRefPtr<WebKitDOMDOMWindow> domWindow = adoptGRef(webkit_dom_document_get_default_view(document));
> +        GRefPtr<WebKitDOMDOMSelection> domSelection = adoptGRef(webkit_dom_dom_window_get_selection(domWindow.get()));

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150720/597f81a8/attachment.html>


More information about the webkit-unassigned mailing list