[Webkit-unassigned] [Bug 147101] New: Unexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA::~GraphicsLayerCA()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=147101

            Bug ID: 147101
           Summary: Unexpected ABI diffference between armv7 and armv7s in
                    WebCore::GraphicsLayerCA::~GraphicsLayerCA()
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: benjamin at webkit.org, dino at apple.com,
                    simon.fraser at apple.com

Unexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA::~GraphicsLayerCA() results in two different symbols:

__ZThn568_N7WebCore15GraphicsLayerCAD0Ev
__ZThn576_N7WebCore15GraphicsLayerCAD0Ev

This is due to the following code in Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:

#if CPU(APPLE_ARMV7S) || defined(TRANSFORMATION_MATRIX_USE_X86_64_SSE2)
#if COMPILER(MSVC)
    __declspec(align(16)) typedef double Matrix4[4][4];
#else
    typedef double Matrix4[4][4] __attribute__((aligned (16)));
#endif
#else
    typedef double Matrix4[4][4];
#endif

We should simply use the same alignment on armv7 to fix this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150720/e4cbb165/attachment-0001.html>