[Webkit-unassigned] [Bug 144099] [GStreamer] Crashes during plugin installation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144099

--- Comment #14 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #13)
> Awesome, thanks!
> 
> I'm not sure about having both
> MediaPlayerRequestInstallMissingPluginsCallback::create and also a public
> constructor; shouldn't the constructor be private, to ensure the ref is
> always adopted?
> 

Yes, not a big issue since nobody else is going to use that, but yes, I can make the constructor private.

> In WebPageProxy::requestInstallMissingMediaPlugins, can't you use a
> protector Ref<WebPageProxy> and capture it in the lambda, instead of the
> manual ref/deref?
> 

That's what I did first, but then I need to leak the ref and I get a compile error because I don't use the returned value of leakRef(). So, I could use a variable that I won't use, or do the ref/deref manually which is what I did in the end.

> What happens when two HTMLMediaElements in the same web process attempt to
> install codecs at the same time? Looks like the first media element will
> never begin to play, right? I guess that's OK; that's quite a corner case.

This hasn't actually changed. In current code gst_install_plugins_async() returns GST_INSTALL_PLUGINS_INSTALL_IN_PROGRESS for the second media player, so m_missingPlugins is set to false and the callback is not called. With this patch the callback is called with GST_INSTALL_PLUGINS_INSTALL_IN_PROGRESS, which is pretty much the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150718/88abde6d/attachment.html>