[Webkit-unassigned] [Bug 144099] [GStreamer] Crashes during plugin installation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144099

--- Comment #13 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Awesome, thanks!

I'm not sure about having both MediaPlayerRequestInstallMissingPluginsCallback::create and also a public constructor; shouldn't the constructor be private, to ensure the ref is always adopted?

In WebPageProxy::requestInstallMissingMediaPlugins, can't you use a protector Ref<WebPageProxy> and capture it in the lambda, instead of the manual ref/deref?

What happens when two HTMLMediaElements in the same web process attempt to install codecs at the same time? Looks like the first media element will never begin to play, right? I guess that's OK; that's quite a corner case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150717/ed547206/attachment.html>