[Webkit-unassigned] [Bug 144956] [ES6] Implement ES6 arrow function syntax. Arrow function specific features. Lexical bind of this

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144956

--- Comment #48 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 256376
  --> https://bugs.webkit.org/attachment.cgi?id=256376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256376&action=review

>> Source/JavaScriptCore/runtime/JSArrowFunction.cpp:101
>> +    // visitor.append(&thisObject->m_arrowFunction);
> 
> This should be fixed.

I can't reproduce this bug now :(. Possible it was fixed somewhere else.

>> Source/JavaScriptCore/runtime/JSArrowFunction.h:69
>> +    const static unsigned StructureFlags = OverridesHasInstance | Base::StructureFlags;
> 
> Looks like you're reporting the wrong things here.
> It should have OverridesVisitChildren and it looks like it should
> not have OverridesHasInstance. 
> 
> Let's see if that fixes GC issues.

I've removed OverridesHasInstance but I didn't find OverridesVisitChildren method.  Anyway it doesn't raise exception with now. Possible it was bug somewhere else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150715/01815465/attachment.html>