[Webkit-unassigned] [Bug 146210] Allow other projects to display on the dashboard

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 13 16:49:08 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146210

Jason Marcell <jmarcell at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255728|0                           |1
        is obsolete|                            |
 Attachment #256746|                            |review?
              Flags|                            |

--- Comment #3 from Jason Marcell <jmarcell at apple.com> ---
Created attachment 256746
  --> https://bugs.webkit.org/attachment.cgi?id=256746&action=review
Patch to allow for projects other than open source and internal on the dashboard.

Dan, I think I've addressed most of your concerns.

One that I'm not sure how to address is this question:
This code is assuming that this.queue.branch represents a dictionary of (project, branch name)-pairs. Currently, this.queue.branch represents a dictionary of (repository, branch name)-pairs. Is this acceptable?

I'm not sure whether this is an issue, but it might be worth discussing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150713/9af2fbc6/attachment-0001.html>


More information about the webkit-unassigned mailing list