[Webkit-unassigned] [Bug 146894] REGRESSION (r177876): store.apple.com profile and cart icons are missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146894

Myles C. Maxfield <mmaxfield at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256683|review?                     |review+
              Flags|                            |

--- Comment #5 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 256683
  --> https://bugs.webkit.org/attachment.cgi?id=256683
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256683&action=review

r=me

> Source/WebCore/platform/graphics/FontCascadeFonts.cpp:339
> +        ++fallbackIndex;

I don't understand. It doesn't look like there is a "continue" anywhere in the loop which will cause this to be skipped. Why did you move this to the bottom of the loop?

>> LayoutTests/fast/css/font-face-multiple-missing-glyphs-expected.html:7
>> +    font-family:AppleIcons;
> 
> Is this available under an appropriate license?

You can author your own font in SVG for this test. Should be straightforward.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150713/b1b93e0c/attachment.html>