[Webkit-unassigned] [Bug 146877] Build failure with: No rule to make target '...Release/include/private/JavaScriptCore/JSInputs.json', needed by 'WebReplayInputs.h'. Stop.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146877

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Same thing for Windows:

Source/JavaScriptCore/JavaScriptCore.vcxproj/copy-files.cmd copies the JSInputs.json as a private headers:

    echo Copying Web Replay specification files as if they were private headers...
    @xcopy /y /d ..\replay\*.json "%PrivateHeadersDirectory%" >NUL

And then WebCore's Derived Sources attempts to use it as expected:

    INPUT_GENERATOR_SPECIFICATIONS = \
        $(WebCore)/replay/WebInputs.json \
        $(WebReplayScripts)/JSInputs.json \
    #

    all : WebReplayInputs.h

    WebReplayInputs.h : $(INPUT_GENERATOR_SPECIFICATIONS) $(INPUT_GENERATOR_SCRIPTS)
        $(PYTHON) $(WebReplayScripts)/CodeGeneratorReplayInputs.py --outputDir . --framework WebCore $(INPUT_GENERATOR_SPECIFICATIONS)

On Windows the $(WebReplayScripts) build variable is setup to point to what looks like the right place:

    WebCore.vcxproj/build-generated-files.pl
    76:$ENV{'WebReplayScripts'} = File::Spec->catdir($XDSTROOT, 'include', 'private', 'JavaScriptCore');

That said, WebCore's `make-generated-sources.sh` meant for manually invoking DerivedSources wouldn't work as is, since the scripts and JSON input are in different places in the source directory:

    make-generated-sources.sh
    6:export WebReplayScripts=$PWD/../JavaScriptCore/replay/scripts

So, other than a possible issue with this script, the regular order of build operations looks reasonable to me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150713/93314bcf/attachment.html>