[Webkit-unassigned] [Bug 146895] New: Watchpoints should be removed from their owning WatchpointSet before they are fired

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146895

            Bug ID: 146895
           Summary: Watchpoints should be removed from their owning
                    WatchpointSet before they are fired
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fpizlo at apple.com

This addresses two issues:

- We have had some weirdo bugs where the watchpoint being fired doesn't kill the watchpoint, and therefore doesn't remove it.  That causes an infinite loop inside WatchpointSet.  We don't have such bugs right now, but it's something that you can hit whenever adding new uses of the watchpoint API.  Having the removal happen before means that we just don't have to worry about this, ever.  OTOH, I can't think of any use of Watchpoint that wants to keep the Watchpoint in the set after it is fired.

- It would be great to write adaptive watchpoints that readd themselves to a different set when they are fired.  But to do this, we need to first remove them from the set that they are currently on.  The easiest API for this is to have the removal happen before fire() is called.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150712/445fcb01/attachment-0001.html>