[Webkit-unassigned] [Bug 146740] New: [GTK] Build race with -DENABLE_WAYLAND_TARGET=ON

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146740

            Bug ID: 146740
           Summary: [GTK] Build race with -DENABLE_WAYLAND_TARGET=ON
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Gtk
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

In file included from ../../Source/WebCore/platform/graphics/PlatformDisplay.cpp:37:
../../Source/WebCore/platform/graphics/wayland/PlatformDisplayWayland.h:32:10: fatal error: 'WebKitGtkWaylandClientProtocol.h' file not found
#include "WebKitGtkWaylandClientProtocol.h"
         ^
1 error generated.

PlatformDisplayWayland.h needs to be built after WebKitGtkWaylandClientProtocol.h. The problem is, it seems like it should be:

# Wayland protocol extension.
add_custom_command(
    OUTPUT ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandClientProtocol.c
    DEPENDS ${WEBCORE_DIR}/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml
    COMMAND wayland-scanner server-header < ${WEBCORE_DIR}/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml > ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandServerProtocol.h
    COMMAND wayland-scanner client-header < ${WEBCORE_DIR}/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml > ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandClientProtocol.h
    COMMAND wayland-scanner code < ${WEBCORE_DIR}/platform/graphics/wayland/WebKitGtkWaylandClientProtocol.xml > ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandClientProtocol.c
)

if (ENABLE_WAYLAND_TARGET)
    list(APPEND WebCorePlatformGTK_SOURCES
        platform/graphics/wayland/PlatformDisplayWayland.cpp
        platform/graphics/wayland/WaylandEventSource.cpp
        platform/graphics/wayland/WaylandSurface.cpp

        ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandClientProtocol.c
    )

    list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
        ${WAYLAND_INCLUDE_DIRS}
    )
    list(APPEND WebCore_LIBRARIES
        ${WAYLAND_LIBRARIES}
    )
endif ()

You can see that ${DERIVED_SOURCES_WEBCORE_DIR}/WebKitGtkWaylandClientProtocol.c is listed as the OUTPUT for a command and also a required source for compiling WebCore. I messed around with adding an explicit dependency, but it didn't help. I'm not sure what's wrong. This might be a CMake bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150708/44425251/attachment.html>