[Webkit-unassigned] [Bug 146702] Add actions to image previews

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146702

--- Comment #5 from Yongjun Zhang <yongjun_zhang at apple.com> ---
Comment on attachment 256337
  --> https://bugs.webkit.org/attachment.cgi?id=256337
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256337&action=review

> Source/WebKit2/UIProcess/WKImagePreviewViewController.h:38
> +    _WKActivatedElementInfo *_activatedElementInfo;

I think we should retain the _activeElementInfo.

> Source/WebKit2/UIProcess/ios/WKActionSheetAssistant.mm:298
> +    NSURL *targetURL = [NSURL URLWithString:positionInformation.url];

Nit: Could we use _web_URLWithWTFString: here?

The patch looks good to me, I will let a WebKit reviewer to comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150708/da23c125/attachment.html>