[Webkit-unassigned] [Bug 146715] Web Inspector: Pressing delete in the styles sidebar with no text causes text to become misaligned

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146715

--- Comment #4 from drousso at apple.com ---
Comment on attachment 256363
  --> https://bugs.webkit.org/attachment.cgi?id=256363
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256363&action=review

>> Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:482
>> +        if (change.origin !== "+delete" || (!change.to.line && !change.to.ch) || this._completionController.isShowingCompletions())
> 
> Does this happen if there is text or only empty? !change.to.line && !change.to.ch will still be true if there is text.

This is only supposed to happen if the cursor is on the first character of the first line, regardless of whether that line has text.  Since pressing delete removes all markers at the cursor's position, if the cursor is at the beginning of a line it will remove the checkbox marker as well as the newline at the beginning of that line.  On the first line, there is no previous line, so pressing delete would just remove the checkbox marker.  We don't want this to happen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150708/38b6358e/attachment.html>