[Webkit-unassigned] [Bug 146671] Web Inspector: Unnecessary space added after -webkit- prefixed property values

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 13:17:50 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146671

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256316|review?                     |review+
              Flags|                            |

--- Comment #7 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 256316
  --> https://bugs.webkit.org/attachment.cgi?id=256316
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256316&action=review

r=me, thanks for addressing all my comments!

> Source/WebInspectorUI/Tools/PrettyPrinting/index.html:54
> +    // Here, the "calc" keyword is added to allow  the do-not-add-whitespace-before-prefixed-property-value

Nit: Double space. Also don't call out a particular test by name, that is the kind of comment that can go stale in the future if that test gets removed or renamed. Just mention its to behave more like the frontend.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150707/5dedc850/attachment.html>


More information about the webkit-unassigned mailing list