[Webkit-unassigned] [Bug 146685] [Win] Add memory pressure handler.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146685

Alex Christensen <achristensen at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256309|review?                     |review-
              Flags|                            |

--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 256309
  --> https://bugs.webkit.org/attachment.cgi?id=256309
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256309&action=review

> Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:85
> +    // Only install a memory check timer for Win32, since Win64 has much more memory to play with.

This is not necessarily true.  64-bit windows can be installed on systems with 1GB of memory, for example.  I don't think the memory pressure handler should be 32-bit only.

> Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp:88
> +    memCheckTimer()->startRepeating(60.0);

This just checks the memory every minute, right?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150707/49190992/attachment.html>