No subject

Tue Jan 27 15:54:36 PST 2015

// FIXME: It's dangerous that OSR exit asks the Executable for a CodeBlock
// instead of having a pointer to a CodeBlock. If the GC discards a
// CodeBlock that we inline, then we will see a different CodeBlock
// at OSR time than we saw at compilation time. This works if compilation
// is mostly pure and the two CodeBlocks are equivalent, but that is a
// fragile thing to rely on.

inline CodeBlock* baselineCodeBlockForInlineCallFrame(InlineCallFrame* inlineCallFrame)
{
    RELEASE_ASSERT(inlineCallFrame);
    ScriptExecutable* executable = inlineCallFrame->executable.get();
    RELEASE_ASSERT(executable->structure()->classInfo() == FunctionExecutable::info());
    return static_cast<FunctionExecutable*>(executable)->baselineCodeBlockFor(inlineCallFrame->specializationKind());
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
--1439941333.4fb7Fddb15.933
Date: Tue, 18 Aug 2015 16:42:13 -0700
MIME-Version: 1.0
Content-Type: text/html

<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - OSR exit should have a direct reference to its target CodeBlock"
   href="https://bugs.webkit.org/show_bug.cgi?id=148152">148152</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>OSR exit should have a direct reference to its target CodeBlock
          </td>
        </tr>

        <tr>
          <th>Classification</th>
          <td>Unclassified
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>WebKit
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>Other
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Unspecified
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>NEW
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>P2
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>JavaScriptCore
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>webkit-unassigned&#64;lists.webkit.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>ggaren&#64;apple.com
          </td>
        </tr></table>
      <p>
        <div>
        <pre>From InlineCallFrame.h:

// FIXME: It's dangerous that OSR exit asks the Executable for a CodeBlock
// instead of having a pointer to a CodeBlock. If the GC discards a
// CodeBlock that we inline, then we will see a different CodeBlock
// at OSR time than we saw at compilation time. This works if compilation
// is mostly pure and the two CodeBlocks are equivalent, but that is a
// fragile thing to rely on.

inline CodeBlock* baselineCodeBlockForInlineCallFrame(InlineCallFrame* inlineCallFrame)
{
    RELEASE_ASSERT(inlineCallFrame);
    ScriptExecutable* executable = inlineCallFrame-&gt;executable.get();
    RELEASE_ASSERT(executable-&gt;structure()-&gt;classInfo() == FunctionExecutable::info());
    return static_cast&lt;FunctionExecutable*&gt;(executable)-&gt;baselineCodeBlockFor(inlineCallFrame-&gt;specializationKind());
}</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>
--1439941333.4fb7Fddb15.933--