[Webkit-unassigned] [Bug 141052] Remove more Mountain Lion code from WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141052

Beth Dakin <bdakin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Beth Dakin <bdakin at apple.com> ---
(In reply to comment #2)
> Comment on attachment 245655 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=245655&action=review
> 
> > Source/WebKit2/config.h:-73
> > -#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> 
> Shouldn't this still be in a PLATFORM(MAC)?
> 

YES! Good catch.

> > Source/WebKit2/Shared/WebPreferencesDefinitions.h:-41
> > -#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090)
> 
> Sam conflicted with you here.
> 

Resolved now.

> > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:-173
> > -#if !PLATFORM(IOS) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
> 
> swap this to PLATFORM(MAC)?

Sure. As we discussed on IRC, there are a lot of these, and they suck. But sure, I will fix this one.

http://trac.webkit.org/changeset/179373

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150129/92b7c8b1/attachment-0002.html>