[Webkit-unassigned] [Bug 140722] Simplify CachedImage clients to avoid overriding both or either only imageChanged or notifyFinished

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140722

--- Comment #14 from Julien Isorce <j.isorce at samsung.com> ---
Comment on attachment 245545
  --> https://bugs.webkit.org/attachment.cgi?id=245545
CachedImage: ensure clients overrides imageChanged instead of notifyFinished

View in context: https://bugs.webkit.org/attachment.cgi?id=245545&action=review

>> Source/WebCore/html/HTMLImageLoader.cpp:77
>> +    ASSERT(cachedImage == image().get());
> 
> It broke the debug builds:
> 
>      1>..\html\HTMLImageLoader.cpp(77): error C2228: left of '.get' must have class/struct/union
>                  type is 'WebCore::CachedImage *'
>                  did you intend to use '->' instead?

Thx for raising it. It should be only image(). I am gonna make a patch right now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150129/94e5b11a/attachment-0002.html>