[Webkit-unassigned] [Bug 140976] http/tests/xmlhttprequest/workers/methods.html sometimes times out with disk cache enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140976

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245579|review?                     |review+
              Flags|                            |

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 245579
  --> https://bugs.webkit.org/attachment.cgi?id=245579
better patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245579&action=review

r=me with nit.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:381
> +            didCallCompletionHandler = true;

Could you please add a ASSERT(!didCallCompletionHandler) before this? I am not 100% convinced this will be called only once with done==Yes, even after reading the doc.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150129/3ddd6dd2/attachment-0002.html>