[Webkit-unassigned] [Bug 141010] Remove Mountain Lion code from WebKit and WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141010

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245571|review?                     |review+
              Flags|                            |

--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 245571
  --> https://bugs.webkit.org/attachment.cgi?id=245571
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245571&action=review

> Source/WebKit2/WebKit2Prefix.h:-60
> -#define WTF_USE_XPC_SERVICES 1

You got this one backwards, we still need WTF_USE_XPC_SERVICES defined to 1. That said, you could actually get rid of this, and just find the one or two users of USE(XPC_SERVICES) and remove them since it should always be true now.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:-4003
>      NSRect contentRect = [[NSScreen mainScreen] frame];
> -#endif

I would get rid of the variable and just do this on the next line.

> Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in:282
>  

I would get rid of this blank line.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150128/f1cdbdf9/attachment-0002.html>