[Webkit-unassigned] [Bug 140938] Refactor the code to handle missing va_end() call after va_start() in String::format

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140938

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245445|review?                     |review-
              Flags|                            |

--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 245445
  --> https://bugs.webkit.org/attachment.cgi?id=245445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245445&action=review

> Source/WTF/wtf/text/WTFString.cpp:469
>      // Not calling va_end/va_start here happens to work on lots of
>      // systems, but fails e.g. on 64bit Linux.

The patch looks good to me, but it needs to remove the orphaned comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150128/194ab2fc/attachment-0002.html>