[Webkit-unassigned] [Bug 140967] Immediate action gesture recognizer still doesn't work well with IB

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140967

Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #245489|review?                     |review-
              Flags|                            |

--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 245489
  --> https://bugs.webkit.org/attachment.cgi?id=245489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=245489&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2571
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000

It looks to me (with a tiny test app) like you're not guaranteed to move to a nil window when moving between windows, so I think this needs to be restructured to avoid re-adding the GR.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2576
> +            [self addGestureRecognizer:_data->_immediateActionGestureRecognizer.get()];

We could keep the controller/GR instantiation in init/commoninit and just add/remove here, for minimal change, if you want.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:2593
> +        if (NSClassFromString(@"NSImmediateActionGestureRecognizer"))

This could check _immediateActionGestureRecognizer instead of this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150128/22782c97/attachment-0002.html>